| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | Craig Ringer <craig(dot)ringer(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Let file_fdw access COPY FROM PROGRAM |
| Date: | 2016-09-13 01:20:20 |
| Message-ID: | e60a3a85-2ce9-f4f9-6dda-e6d8739eae50@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2016/09/13 2:01, Corey Huinker wrote:
> Thanks for the review!
>
> I agree with all the code cleanups suggested and have made then in the
> attached patch, to save the committer some time.
Thanks. Have already marked the patch as ready for the committer.
> Also in this patch, I changed sgml para to
> <para>
> Changing table-level options requires superuser privileges, for security
> reasons: only a superuser should be able to determine which file is read
> or which program is run. In principle non-superusers could be allowed to
> change the other options, but that's not supported at present.
> </para>
>
> "Determine" is an odd word in this context. I understand it to mean
> "set/change", but I can see where a less familiar reader would take the
> meaning to be "has permission to see the value already set". Either way,
> it now mentions program as an option in addition to filename.
Agreed.
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-09-13 01:35:38 | Re: pg_basebackup, pg_receivexlog and data durability (was: silent data loss with ext4 / all current versions) |
| Previous Message | Craig Ringer | 2016-09-13 00:55:42 | Re: Logical Replication WIP |