Re: [patch] plproxy v2

From: "Marko Kreen" <markokr(at)gmail(dot)com>
To: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
Cc: "Simon Riggs" <simon(at)2ndquadrant(dot)com>, "Postgres Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [patch] plproxy v2
Date: 2008-07-08 16:16:10
Message-ID: e51f66da0807080916h67bdc9c9o73b1834a8ea86965@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 7/8/08, Joshua D. Drake <jd(at)commandprompt(dot)com> wrote:
> On Tue, 2008-07-08 at 18:43 +0300, Marko Kreen wrote:
> > On 7/8/08, Joshua D. Drake <jd(at)commandprompt(dot)com> wrote:
>
> > > First let me say that I too enjoy PL/Proxy quite a bit. However, I don't
> > > think it needs to be in core. I wouldn't mind seeing it in contrib (or
> > > better yet modules/ should we ever get around to that).
> >
> > I'm not against contrib/ considering that the docs are now nicely
> > integrated, but then, whats the difference between src/pl/ and contrib/?
>
> I am actually against adding to the grammar which is what Simon was
> suggesting. If it wants to go into src/pl I wouldn't have a problem with
> that. Sorry for not being more clear.

Current patch is for src/pl/. Diffstat for patch v2:

doc/src/sgml/filelist.sgml | 1
doc/src/sgml/plproxy.sgml | 221 ++++++
doc/src/sgml/postgres.sgml | 1
src/include/catalog/pg_pltemplate.h | 1
src/pl/Makefile | 2
src/pl/plproxy/Makefile | 89 ++
src/pl/plproxy/cluster.c | 469 +++++++++++++
src/pl/plproxy/execute.c | 724 +++++++++++++++++++++
src/pl/plproxy/expected/plproxy_clustermap.out | 71 ++
src/pl/plproxy/expected/plproxy_dynamic_record.out | 51 +
src/pl/plproxy/expected/plproxy_errors.out | 66 +
src/pl/plproxy/expected/plproxy_init.out | 2
src/pl/plproxy/expected/plproxy_many.out | 116 +++
src/pl/plproxy/expected/plproxy_select.out | 37 +
src/pl/plproxy/expected/plproxy_test.out | 312 +++++++++
src/pl/plproxy/function.c | 479 +++++++++++++
src/pl/plproxy/main.c | 214 ++++++
src/pl/plproxy/parser.y | 203 +++++
src/pl/plproxy/plproxy.h | 301 ++++++++
src/pl/plproxy/poll_compat.c | 140 ++++
src/pl/plproxy/poll_compat.h | 58 +
src/pl/plproxy/query.c | 316 +++++++++
src/pl/plproxy/result.c | 222 ++++++
src/pl/plproxy/rowstamp.h | 27
src/pl/plproxy/scanner.l | 320 +++++++++
src/pl/plproxy/sql/plproxy_clustermap.sql | 56 +
src/pl/plproxy/sql/plproxy_dynamic_record.sql | 43 +
src/pl/plproxy/sql/plproxy_errors.sql | 63 +
src/pl/plproxy/sql/plproxy_init.sql | 57 +
src/pl/plproxy/sql/plproxy_many.sql | 66 +
src/pl/plproxy/sql/plproxy_select.sql | 37 +
src/pl/plproxy/sql/plproxy_test.sql | 200 +++++
src/pl/plproxy/type.c | 336 +++++++++
33 files changed, 5299 insertions(+), 2 modifications(!)

--
marko

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2008-07-08 16:31:41 Re: [WIP] patch - Collation at database level
Previous Message Marko Kreen 2008-07-08 16:13:10 Re: [patch] plproxy v2