From: | "Marko Kreen" <markokr(at)gmail(dot)com> |
---|---|
To: | "Magnus Hagander" <magnus(at)hagander(dot)net> |
Cc: | "Jan Wieck" <wieck(at)postgresql(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Added the Skytools extended transaction ID module to contrib as |
Date: | 2007-10-08 18:54:56 |
Message-ID: | e51f66da0710081154q4e219d61t4b41753914cb720a@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 10/8/07, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> Marko Kreen wrote:
> > On 10/8/07, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> >> On Sun, Oct 07, 2007 at 11:32:19PM +0000, Jan Wieck wrote:
> >>> Log Message:
> >>> -----------
> >>> Added the Skytools extended transaction ID module to contrib as discussed
> >>> on CORE previously.
> >
> > To explain the situation, the public discussion about the current
> > submission happened here:
> >
> > http://lists.pgfoundry.org/pipermail/skytools-users/2007-September/000245.html
> >
> > and here:
> >
> > http://lists.slony.info/pipermail/slony1-hackers/2007-September/000057.html
>
> Ok. That certainly explains it - it did sound weird to have that go in
> without any public discussion at all - but none of those lists are
> pgsql-hackers ;-)
Yes, sorry about that. Just the discussion started very
hypetetically, with us probing each other opinion, and there
was nothing to discuss with -hackers.
When we saw a concrete plan for the module, then it was too late
to do a regular -hackers submission, due to the beta timeline
we needed -core opinion immidiately.
Now, after -core gave a nod, then yes, the patch should have been
to -hackers with a notice that it is on fast-path.
[btw, this is me guessing Jan's thinking, but I would have
acted same way.]
> > Now as you can read from recent disussion we had, we found out
> > that it would be *really* *really* cool if it would appear
> > in 8.3... Talk about last moment...
>
> Well, if it's really really cool to have, why do we put it in /contrib?
> If it's that cool, it should be in core, no?
Main cool thing came from fact that this is the last moment
Slony could do such big conversion of it's codebase.
> That's not just making comments, I really *do* think that it should be
> in core if it's interesting enough to be added to contrib at this time.
Yes, it is cool enough to be in core and I think that's the goal.
But asking for it to be accepted to core a week before beta and
couple months after feature freeze would be asking bit too much,
don't you think? ;)
--
marko
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-10-08 20:25:40 | pgsql: Get rid of dependency on strtoull() --- Marko Kreen. |
Previous Message | Jan Wieck | 2007-10-08 18:51:59 | Re: [COMMITTERS] pgsql: Added the Skytools extended transaction ID module to contrib as |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2007-10-08 18:57:38 | Re: [COMMITTERS] pgsql: Added the Skytools extended trans actionID module to contrib as |
Previous Message | Jan Wieck | 2007-10-08 18:51:59 | Re: [COMMITTERS] pgsql: Added the Skytools extended transaction ID module to contrib as |