Re: Is "Window" really safe as a global typedef name?

From: "Hitoshi Harada" <umi(dot)tanuki(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Heikki Linnakangas" <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Is "Window" really safe as a global typedef name?
Date: 2008-12-22 04:57:42
Message-ID: e08cc0400812212057v46350c5n8544b03265c3ce86@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2008/12/22 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> "Hitoshi Harada" <umi(dot)tanuki(at)gmail(dot)com> writes:
>> 2008/12/21 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>>> Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
>>>> WindowAgg?
>>>
>>> WindowAgg seems like a winner to me, because it draws a parallel to
>>> the regular Agg node type, which seems valid unless I've completely
>>> misunderstood what's happening...
>
>> I disagree with WindowAgg. The aggregates are subset of window
>> functions in the node, though much code is similar and ported from
>> nodeAgg.
>
> So? If Agg does a subset of what WindowAgg does, all the more reason
> to use that name.
>

OK. I thought WindowAgg means some kind of subset of Agg, but if it
means Window (And) Agg then it makes sense to me.

Regards,

--
Hitoshi Harada

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alex Hunsaker 2008-12-22 05:37:50 Re: contrib/pg_stat_statements 1212
Previous Message Hitoshi Harada 2008-12-22 04:55:27 Re: Location for window function API definitions