Re: unsafe use of hash_search(... HASH_ENTER ...)

From: "Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: unsafe use of hash_search(... HASH_ENTER ...)
Date: 2005-06-09 03:41:36
Message-ID: d88dtg$198f$1@news.hub.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes
>
> This is not an issue except if the system might actually try to recover;
> which is not the case in the postmaster snippet you mention.
>

Yeah, you are right. I scratched elog/ereport(FATAL/PANIC), only found this
one might be a suspect:

In _hash_expandtable():

if (!_hash_try_getlock(rel, start_nblkno, HASH_EXCLUSIVE))
elog(PANIC, "could not get lock on supposedly new bucket");

Or maybe elog(PANIC) is a false alarm here?

Regards,
Qingqing

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-06-09 03:58:20 Re: [HACKERS] Should *.backup files ever be removed from pg_xlog?
Previous Message Marc G. Fournier 2005-06-09 03:26:06 Re: pg_config --configure ...