Re: GUC custom variables broken

From: Thomas Hallgren <thhal(at)mailblocks(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: GUC custom variables broken
Date: 2004-11-11 23:47:46
Message-ID: cn0tn2$v3q$1@sea.gmane.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Thomas Hallgren wrote:
> I have the following in my postgresql.conf
>
> custom_variable_classes = 'pljava'
> pljava.classpath =
> 'C:\\Tada\\Workspace\\org.postgresql.pljava\\build\\pljava.jar'
>
> It worked fine with 8.0.0beta2. The beta4 however, gives me the
> following message:
>
> FATAL: unrecognized configuration parameter "pljava.classpath"
>
> What happened?
>
Ah, I see what's wrong. It's in the guc_file.l

Previously, the "custom_variable_classes" was *set* first of all
variables. Now, it's moved first in the linked list and then *tested*
first of all. Subsequent tests of custom variables will of course then
fail since the custom_variable_classes has not been set.

Perhaps this change could be reverted? Or perhaps someone has other
preferences on implementation?

Regards,
Thomas Hallgren

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Tom Lane 2004-11-11 23:48:00 Re: invalid page header in block 52979 of relation "pg_attribute"
Previous Message Tom Lane 2004-11-11 23:45:35 Re: GUC custom variables broken

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Hallgren 2004-11-12 00:00:44 Re: GUC custom variables broken
Previous Message Tom Lane 2004-11-11 23:45:35 Re: GUC custom variables broken