| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
| Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Steve Singer <steve(at)ssinger(dot)info> |
| Subject: | Re: Logical Replication WIP |
| Date: | 2016-11-04 02:05:49 |
| Message-ID: | cb18f96c-b124-3502-568f-affb86d37217@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/24/16 9:22 AM, Petr Jelinek wrote:
> I also split out the libpqwalreceiver rewrite to separate patch which
> does just the re-architecture and does not really add new functionality.
> And I did the re-architecture bit differently based on the review.
That looks good to me, and it appears to address the previous discussions.
I wouldn't change walrcv_xxx to walrcvconn_xxx. If we're going to have
macros to hide the internals, we might as well keep the names the same.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2016-11-04 02:59:47 | Re: Confusing docs about GetForeignUpperPaths in fdwhandler.sgml |
| Previous Message | Peter Eisentraut | 2016-11-04 01:45:28 | Re: Logical Replication WIP |