Re: [COMMITTERS] pgsql: Add GUC temp_tablespaces to provide a default location for

From: "Jaime Casanova" <systemguards(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Bruce Momjian" <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Add GUC temp_tablespaces to provide a default location for
Date: 2007-03-17 15:10:38
Message-ID: c2d9e70e0703170810i6acc6349rced3f2e0d6ab6e42@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-patches

On 3/5/07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> In the second place, it's a serious violation of what little modularity
> and layering we have for fd.c to be calling into commands/tablespace.c.
> This is not merely cosmetic but has real consequences: one being that
> it's now unsafe to call OpenTemporaryFile outside a transaction.
>

ok, you are right... what do you suggest?
maybe move the GetTempTablespace function to somewhere in src/backend/utils?

--
regards,
Jaime Casanova

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs and the universe trying
to produce bigger and better idiots.
So far, the universe is winning."
Richard Cook

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message User Eggyknap 2007-03-17 15:16:50 pgsnmpd - pgsnmpd: Starting to resurrect the build
Previous Message Magnus Hagander 2007-03-17 14:30:00 pgsql: Add note that diff is required for regression tests.

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Meskes 2007-03-17 15:29:50 Re: SoC ECPG Enhancements
Previous Message Andrew Dunstan 2007-03-17 14:48:10 Re: [PATCHES] xpath_array with namespaces support

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-03-17 15:36:29 Re: [COMMITTERS] pgsql: Add GUC temp_tablespaces to provide a default location for
Previous Message Andrew Dunstan 2007-03-17 14:48:10 Re: [PATCHES] xpath_array with namespaces support