Re: pgsql: Remove inappropriate memory context switch in

From: "Neil Conway" <neilc(at)samurai(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Remove inappropriate memory context switch in
Date: 2008-11-30 21:03:29
Message-ID: b4e5ce320811301303w4d1878fch50431c8fa3aecf25@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sun, Nov 30, 2008 at 10:49 AM, Tom Lane <tgl(at)postgresql(dot)org> wrote:
> Remove inappropriate memory context switch in shutdown_MultiFuncCall().
> This was a thinko introduced in a patch from last February; it results
> in memory leakage if an SRF is shut down before the actual end of query,
> because subsequent code will be running in a longer-lived context than
> it's expecting to be.

I added that context switch for a reason:

http://archives.postgresql.org/pgsql-patches/2008-02/msg00153.php

Presumably that's why the build farm is crashing on dblink.

Neil

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2008-11-30 21:09:18 Re: pgsql: Remove inappropriate memory context switch in
Previous Message Tom Lane 2008-11-30 20:51:25 pgsql: Clean up the API for DestReceiver objects by eliminating the

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-11-30 21:09:18 Re: pgsql: Remove inappropriate memory context switch in
Previous Message Pavel Stehule 2008-11-30 20:13:50 Re: WIP: default values for function parameters