From: | tgl(at)postgresql(dot)org (Tom Lane) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Clean up the API for DestReceiver objects by eliminating the |
Date: | 2008-11-30 20:51:25 |
Message-ID: | 20081130205125.BC49F7545A4@cvs.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
Clean up the API for DestReceiver objects by eliminating the assumption
that a Portal is a useful and sufficient additional argument for
CreateDestReceiver --- it just isn't, in most cases. Instead formalize
the approach of passing any needed parameters to the receiver separately.
One unexpected benefit of this change is that we can declare typedef Portal
in a less surprising location.
This patch is just code rearrangement and doesn't change any functionality.
I'll tackle the HOLD-cursor-vs-toast problem in a follow-on patch.
Modified Files:
--------------
pgsql/src/backend/access/common:
printtup.c (r1.102 -> r1.103)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/common/printtup.c?r1=1.102&r2=1.103)
pgsql/src/backend/commands:
copy.c (r1.301 -> r1.302)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/copy.c?r1=1.301&r2=1.302)
portalcmds.c (r1.75 -> r1.76)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/portalcmds.c?r1=1.75&r2=1.76)
pgsql/src/backend/executor:
execMain.c (r1.318 -> r1.319)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/execMain.c?r1=1.318&r2=1.319)
functions.c (r1.129 -> r1.130)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/functions.c?r1=1.129&r2=1.130)
spi.c (r1.200 -> r1.201)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/spi.c?r1=1.200&r2=1.201)
tstoreReceiver.c (r1.19 -> r1.20)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/tstoreReceiver.c?r1=1.19&r2=1.20)
pgsql/src/backend/tcop:
dest.c (r1.73 -> r1.74)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/dest.c?r1=1.73&r2=1.74)
postgres.c (r1.557 -> r1.558)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/postgres.c?r1=1.557&r2=1.558)
pquery.c (r1.125 -> r1.126)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/pquery.c?r1=1.125&r2=1.126)
pgsql/src/include/access:
printtup.h (r1.36 -> r1.37)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/access/printtup.h?r1=1.36&r2=1.37)
pgsql/src/include/executor:
tstoreReceiver.h (r1.10 -> r1.11)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/executor/tstoreReceiver.h?r1=1.10&r2=1.11)
pgsql/src/include/tcop:
dest.h (r1.55 -> r1.56)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/tcop/dest.h?r1=1.55&r2=1.56)
pgsql/src/include/utils:
portal.h (r1.79 -> r1.80)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/portal.h?r1=1.79&r2=1.80)
From | Date | Subject | |
---|---|---|---|
Next Message | Neil Conway | 2008-11-30 21:03:29 | Re: pgsql: Remove inappropriate memory context switch in |
Previous Message | Tom Lane | 2008-11-30 19:01:29 | pgsql: Add a "LIKE = typename" clause to CREATE TYPE for base types. |