| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Use latch instead of select() in walreceiver |
| Date: | 2016-12-04 01:16:12 |
| Message-ID: | b4be6ea7-1e88-1cd3-d179-e31985b3f2e9@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 12/1/16 8:50 PM, Michael Paquier wrote:
> + if (rc & WL_POSTMASTER_DEATH)
> + exit(1);
> Hmm. We have always been very careful about not leaving immediately
> from libpqwalreceiver.c which is an independent shared library so as
> the WAL receiver can take cleanup actions. See here for more details:
> https://www.postgresql.org/message-id/CAEepm=0hg_FX7kdUhosTpJ_kPsUZw6k-7nuQNy-dGAOaetn_tA@mail.gmail.com
walreceiver.c does the same thing. The message you pointed out is not
exactly clear why that would be wrong.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2016-12-04 05:26:14 | pgsql: Make pgwin32_putenv() probe every known CRT, regardless of compi |
| Previous Message | Noah Misch | 2016-12-03 20:58:45 | Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2016-12-04 01:29:01 | Re: Parallel tuplesort (for parallel B-Tree index creation) |
| Previous Message | Peter Eisentraut | 2016-12-04 01:06:53 | Re: Logical Replication WIP |