| From: | "Merlin Moncure" <mmoncure(at)gmail(dot)com> |
|---|---|
| To: | "Alvaro Herrera" <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | "Andrew Chernow" <ac(at)esilo(dot)com>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: PQParam version 0.5 |
| Date: | 2007-12-05 19:48:46 |
| Message-ID: | b42b73150712051148vf9fdb25rf7f01750c1c299d2@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Dec 5, 2007 2:44 PM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Andrew Chernow escribió:
>
> > Also changed PQputint8's prototype. Previously, it was using a void* as
> > the value argument, due to a lack of a portable 64-bit type in libpq. We
> > found an intersting way around this by using macro and variable argument
> > tricks.
>
> I didn't read the patch, but variadic macros are not portable. FWIW
> uint64 should "portable" to all platforms that have it (and it should be
> 32 bits on platforms that don't), but you have to watch for
> INT64_IS_BUSTED.
we don't use variadic macros...just a macro wrapper to a variadic function.
merlin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Chernow | 2007-12-05 20:03:02 | Re: PQParam version 0.5 |
| Previous Message | Alvaro Herrera | 2007-12-05 19:44:25 | Re: PQParam version 0.5 |