| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, Sandeep Thakkar <sandeep(dot)thakkar(at)enterprisedb(dot)com> |
| Cc: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c) |
| Date: | 2018-08-22 14:56:15 |
| Message-ID: | aff7c79c-e05c-ed59-ad3a-123823846312@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-www |
On 22/08/2018 14:02, Andres Freund wrote:
> If we agree on that, I'm going to propose a patch that includes:
> - relevant cleanups to configure
> - adapts sources.sgml to refer to C99 instead of C89
> - add some trivial conversions to for(int i;;) and struct initializers,
> so the relevant old animals fail
> - adds a configure check to enable errors with vla usage (-Werror=vla)
sounds good
> - do we want to make declarations at arbitrary points errors? It's
> already a warning currently.
While there are legitimate criticisms, it's a standard feature in C,
C++, and many other languages, so I don't see what we'd gain by fighting it.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-08-22 15:01:47 | Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c) |
| Previous Message | Andres Freund | 2018-08-22 14:54:11 | Re: JIT compiling with LLVM v12 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-08-22 15:01:47 | Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c) |
| Previous Message | Sandeep Thakkar | 2018-08-22 12:22:11 | Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c) |