Re: some pg_dump query code simplification

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: some pg_dump query code simplification
Date: 2018-08-29 12:51:26
Message-ID: a5f3b498-2b7a-5a02-77c5-3db33b2b0086@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 08/28/2018 06:10 PM, Stephen Frost wrote:
>
>> Andrew has a buildfarm module that does precisely that, although
>> I'm not sure what its test dataset is --- probably the regression
>> database from each branch. I also have a habit of doing such testing
>> manually whenever I touch version-sensitive parts of pg_dump.
> I've gotten better about doing that back-branch testing myself and
> certainly prefer it, but I think we should also have buildfarm coverage.
> I don't think we have the full matrix covered, or, really, anything
> anywhere near it, so I'm looking for other options to at least get that
> code exercised.
>
>

If by matrix you mean the version matrix, then the module in question
covers every live branch as the source and every same or later live
branch as the destination.

It could conceivably cover older branches as well - the branch names
aren't actually hardcoded - I'd just have to be able to build them and
do a standard buildfarm run once.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Kukushkin 2018-08-29 13:05:25 Re: BUG #15346: Replica fails to start after the crash
Previous Message Andrew Dunstan 2018-08-29 12:46:02 Re: some pg_dump query code simplification