Re: WIP: About CMake v2

From: Mark Kirkwood <mark(dot)kirkwood(at)catalyst(dot)net(dot)nz>
To: Yury Zhuravlev <u(dot)zhuravlev(at)postgrespro(dot)ru>, pgsql-hackers(at)postgresql(dot)org
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Subject: Re: WIP: About CMake v2
Date: 2016-11-16 22:14:24
Message-ID: a4ebb1ae-2ac8-c492-1cb4-73e9ad6bbea7@catalyst.net.nz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I see there are some patches for the putenv issue with Visual studio
2013 in progress on this list - it is probably best to work with the
author to see if 2015 has any new issues and keep all changes for that
*out* of the cmake patches.

regards

Mark

On 16/11/16 21:22, Yury Zhuravlev wrote:
> I made this small wrapper special for MSVC 2015 without Service Packs
> because postgres macross were in conflict with MS internal functions.
> After some time and some updates for MSVC Michael Paquier could not
> reproduce my problem but I keep this patch to avoid problems in the
> future. I can check old behavior again and revert all changes if
> needed and ofcourse I have plans to make separate patch for this changes.
> Thanks!

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-11-16 22:22:30 Re: WIP: About CMake v2
Previous Message Tom Lane 2016-11-16 21:48:19 Re: Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default