Re: Datetime patch

From: greg(at)turnstep(dot)com
To: pgsql-patches(at)postgresql(dot)org
Subject: Re: Datetime patch
Date: 2003-07-25 15:12:13
Message-ID: a389ef3bb1701d92d756b567a9518202@biglumber.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> Greg, does this patch still reject dates with month/days out of range?
> I see some of the range checks are removed. Where those checks used
> only for the month/date detection?

Yes and yes. The range rejection in the previous code only allowed an
invalid date to be detected earlier than it would have otherwise. It is
the responsibility of the code following it to determine the validity of
the date we construct here.

Some very minimal checking could be put into place, but it would just be
a small subset of the full checking that occurs later on, so it seemed
better to leave all that logic in one place.

- --
Greg Sabino Mullane greg(at)turnstep(dot)com
PGP Key: 0x14964AC8 200307251104
-----BEGIN PGP SIGNATURE-----
Comment: http://www.turnstep.com/pgp.html

iD8DBQE/IUhQvJuQZxSWSsgRAthUAJ42qjxGOVRX/Ak/RF5z0KlZu2CUQwCfeYoy
IxRZhzqzNWJM8NeqFKLGesE=
=4rCE
-----END PGP SIGNATURE-----

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2003-07-25 15:31:14 Re: best way to determine start of new statement within
Previous Message Bruce Momjian 2003-07-25 15:02:58 Re: flex 2.5.31

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-07-25 17:28:14 Re: Datetime patch
Previous Message Bruce Momjian 2003-07-25 15:07:04 Re: PG Patch (fwd) [openserver patch followup #2]