Skip site navigation (1) Skip section navigation (2)

Re: Patch to add Heimdal kerberos support

From: Bill Studenmund <wrstuden(at)netbsd(dot)org>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Patch to add Heimdal kerberos support
Date: 2001-11-28 02:04:55
Message-ID: Pine.NEB.4.33.0111271746270.11101-100000@vespasia.home-net.internetconnect.net (view raw or flat)
Thread:
Lists: pgsql-patches
On Sat, 17 Nov 2001, Peter Eisentraut wrote:

> Bill Studenmund writes:
>
> > The problem I had with AC_SEARCH_LIBS was that if I don't add all of the
> > libraries (-lasn1 -lroken etc.) the test program won't compile, even
> > though the .o compiles fine. Can we make the test only depend on
> > generating a .o?
>
> That wouldn't tell you a whole lot about the existence of a function.  You
> do need to link to be able to verify that.

The thought was that the existance of the symbol (not function)
__heimdal_version is an easy way to tell which version is in use.

> > I'd like to make it a bug fix for 7.2 if we can, so I'd appreciate the
> > help. I can test any new versions of the patch. :-)
>
> The attached patch should handle the different struct members (at least it
> doesn't break them for me) and it doesn't gratuitously fail on libraries
> that are not really needed.  I haven't done anything about -lasn1 -lroken
> -lcrypto because I'd need to know what functions you need from there.  You
> should be able to get it to work when you configure thus:

Well, the real problem is that libkrb5 needs these libraries. More
importantly, the tests to see if libkrb5 is ok need them. :-)

> $ LIBS='-lasn1 -lroken -lcrypto' ./configure --with-krb5 ...other options...

Unfortunatly that won't work as libasn1 needs libcom_err. So the above
line complains that gcc is broken. :-(

So what needs to happen is that libasn1, libroken, and libcrypto need to
be looked for part way through the kerberos tests, if we have heimdal. If
we have MIT, we shouldn't look for them.

Well, more to the point, not having working libasn1 and libroken is only a
problem for heimdal; it's an ok state of affairs for MIT kerberos.

Thoughts?

> If you can confirm that this patch works I can check it in so it appears
> in whatever beta3+1 is going to be.  However, be aware that we're
> approaching the first release candidate, and since this issue doesn't
> represent a regression from 7.1 it's not going to hold up the release.

I understand.

Take care,

Bill


In response to

pgsql-patches by date

Next:From: Christopher Kings-LynneDate: 2001-11-28 02:17:49
Subject: Re: Support for QNX6, POSIX IPC and PTHREAD-style locking
Previous:From: Greg Sabino MullaneDate: 2001-11-27 21:23:51
Subject: Updated version of src/bin/psql/create_help.pl

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group