S_LOCK() change produces error...

From: The Hermit Hacker <scrappy(at)hub(dot)org>
To: pgsql-hackers(at)postgresql(dot)org
Subject: S_LOCK() change produces error...
Date: 1998-01-18 01:38:48
Message-ID: Pine.NEB.3.96.980117213702.259C-100000@thelab.hub.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


I installed some patches today for the univel port, and one of the changes
did the following to include/storage/s_lock.h:

302c318
< __asm__("xchgb %0,%1": "=q"(_res), "=m"(*lock):"0"(0x1)); \
---
> __asm__("lock xchgb %0,%1": "=q"(_res), "=m"(*lock):"0"(0x1)); \

Under FreeBSD, this breaks the compile with an 'unimplemented' error...I'm
not going to commit the "fix" yet (reverse the patch)...does this break other
ports as well, or just FreeBSD? Anyone with Assembler experience out there? :)

Marc G. Fournier
Systems Administrator @ hub.org
primary: scrappy(at)hub(dot)org secondary: scrappy(at){freebsd|postgresql}.org

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message The Hermit Hacker 1998-01-18 01:55:25 free() error in current source tree under FreeBSD...
Previous Message Darren King 1998-01-17 23:44:54 Re: [HACKERS] Re: [QUESTIONS] Business cases