Re: patch implementing the multi-argument aggregates (SOC

From: "Sergey E(dot) Koposov" <math(at)sai(dot)msu(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: patch implementing the multi-argument aggregates (SOC
Date: 2006-07-25 09:39:50
Message-ID: Pine.LNX.4.64.0607251322080.19158@lnfm1.sai.msu.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Some small clean-up of the patch...

+ implementing the Tom's idea of minimizing the copying of the data inside
advance_transition_function by using the temporary FunctionCallInfoData
(now the computed arguments of the aggregates are putted directly into
proper fcinfo.args fields, ready for the transition function call).

On Mon, 24 Jul 2006, Tom Lane wrote:
> Instead of copying data inside advance_transition_function, it might
> be better for the caller to store the values into the right fields
> of a temporary FunctionCallInfoData struct, and just pass that to
> advance_transition_function.

Regards,
Sergey

*******************************************************************
Sergey E. Koposov
Max Planck Institute for Astronomy/Sternberg Astronomical Institute
Tel: +49-6221-528-349
Web: http://lnfm1.sai.msu.ru/~math
E-mail: math(at)sai(dot)msu(dot)ru

Attachment Content-Type Size
PolyArgAggs1.diff text/plain 139.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gevik Babakhani 2006-07-25 10:01:41 root/administartor user check option.
Previous Message ITAGAKI Takahiro 2006-07-25 08:20:37 Re: Resurrecting per-page cleaner for btree

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-07-25 11:54:26 Re: Resurrecting per-page cleaner for btree
Previous Message ITAGAKI Takahiro 2006-07-25 08:20:37 Re: Resurrecting per-page cleaner for btree