| From: | Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> |
|---|---|
| To: | "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Gregory Stark <stark(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCHES] Trivial patch to double vacuum speed |
| Date: | 2006-09-04 23:57:29 |
| Message-ID: | Pine.LNX.4.58.0609050952440.11401@linuxworld.com.au |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
On Mon, 4 Sep 2006, Joshua D. Drake wrote:
>
> > I don't have a concrete proposal to make, but I do think that the
> > current patch-queue process is not suited to the project as it stands
> > today. Maybe if this issue-tracking stuff gets off the ground, we
> > could let developers place ACK or NAK flags on patches they've looked
> > at, and have some rule about ACK-vs-NAK requirements for something to go
> > in.
>
> How about *requiring* test cases that prove the patch?
People including regression tests is not a replacement for code review.
For a non-trivial patch, an SQL test will only exercise a few code paths.
Moreover, it wont say anything about code quality, maintainability or
general correctness or completeness. It will still have to be reviewed.
Thanks
Gavin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-09-05 00:02:44 | Re: [COMMITTERS] pgsql: Sequences were not being shown due to the use of lowercase `s` |
| Previous Message | Bruce Momjian | 2006-09-04 23:57:24 | Re: GIN FailedAssertions on Itanium2 with Intel |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua D. Drake | 2006-09-05 00:05:41 | Re: [PATCHES] Trivial patch to double vacuum speed |
| Previous Message | Tom Lane | 2006-09-04 23:57:22 | Re: [PATCHES] Trivial patch to double vacuum speed |