| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Gregory Stark <stark(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCHES] Trivial patch to double vacuum speed |
| Date: | 2006-09-04 23:57:22 |
| Message-ID: | 16174.1157414242@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
"Joshua D. Drake" <jd(at)commandprompt(dot)com> writes:
> How about *requiring* test cases that prove the patch?
There are lots and lots of things that can't really be tested with
pg_regress-based tests, and in any case a test does not prove the
absence of bugs; particularly not a test devised by the code author,
since almost by definition it won't test cases he didn't think of.
Certainly test cases have their place, but I have a lot more faith in
code-reading by knowledgeable developers as a way to spot problems
that got past the original author.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2006-09-04 23:57:24 | Re: GIN FailedAssertions on Itanium2 with Intel |
| Previous Message | Bruce Momjian | 2006-09-04 23:52:38 | Re: [PATCHES] Trivial patch to double vacuum speed |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gavin Sherry | 2006-09-04 23:57:29 | Re: [PATCHES] Trivial patch to double vacuum speed |
| Previous Message | Bruce Momjian | 2006-09-04 23:52:38 | Re: [PATCHES] Trivial patch to double vacuum speed |