Re: pgxs: build infrastructure for extensions v1

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pgxs: build infrastructure for extensions v1
Date: 2004-06-19 12:44:35
Message-ID: Pine.LNX.4.58.0406191435430.1550@mordor.coelho.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Dear Peter,

Thanks a lot for all these comments. I'll try to update my patch in the
coming week, or maybe this weekend.

Some responses to some of your comments:

> - Please don't invent new targets like light-install, install-local.
> Just install everything in the install target.

The current status is that there are two targets: "install" and
"server-install". As I think that "server-install" should be the default,
I renamed it "install", but I wanted to let the old "install" still
available, thus I had to find a name for it, hence "light-install". It
is the install a packager would like to chose, to have a separate -dev
package.

> - Referring to the renaming of all makefiles under contrib/: I'm not in
> favor of naming makefiles Makefile.foo; it should be foo.mk. This
> makes it easier for tools that recognize files by extension.

Ok. Actually, the "Makefile.pgxs" is the template "example" makefile, so
its status is different from others that are to be included.

Thanks again,

--
Fabien Coelho - coelho(at)cri(dot)ensmp(dot)fr

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-06-19 15:19:31 Re: Tablespace patch review
Previous Message Gavin Sherry 2004-06-19 12:05:51 Admin guide tablespace docs