| From: | Reinhard Max <max(at)suse(dot)de> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, <elf(at)solvo(dot)ru>, <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: libpgtcl doesn't use UTF encoding of TCL |
| Date: | 2001-07-20 15:09:03 |
| Message-ID: | Pine.LNX.4.33.0107201634560.15079-100000@wotan.suse.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers pgsql-interfaces |
On Fri, 20 Jul 2001, Peter Eisentraut wrote:
> Reinhard Max writes:
>
> > OK, I'll pack the new stuff inside #ifdef TCL_UTF8 and define that if
> > the Tcl version is 8.1 or greater.
>
> No, please add a configure check for Tcl_UtfToExternalDString or
> some other function representative of this interface..
Why make simple things complicated?
Tcl changed it's internal string representation starting with release
8.1 . It is not an interface one can decide whether to use it or not.
Every extension that imports or exports strings and gets compiled for
Tcl >= 8.1 has to make sure that they are UTF8 regardless, if it uses
the Tcl_*Utf*DString functions or something else. So I consider it
sufficient to define TCL_UTF8 if Tcl's Version is >= 8.1 as I did in
the patch that was attached to my last mail.
cu
Reinhard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2001-07-20 15:16:16 | Re: libpgtcl doesn't use UTF encoding of TCL |
| Previous Message | Peter Eisentraut | 2001-07-20 14:22:08 | Re: libpgtcl doesn't use UTF encoding of TCL |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2001-07-20 15:16:16 | Re: libpgtcl doesn't use UTF encoding of TCL |
| Previous Message | Lamar Owen | 2001-07-20 15:07:05 | Re: RPM source files should be in CVS (was Re: psql -l) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2001-07-20 15:16:16 | Re: libpgtcl doesn't use UTF encoding of TCL |
| Previous Message | Peter Eisentraut | 2001-07-20 14:22:08 | Re: libpgtcl doesn't use UTF encoding of TCL |