| From: | Anders Bengtsson <ndrsbngtssn(at)yahoo(dot)se> |
|---|---|
| To: | Barry Lind <barry(at)xythos(dot)com> |
| Cc: | <pgsql-jdbc(at)postgresql(dot)org>, <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] Re: [PATCH] Cleanup of JDBC character encoding |
| Date: | 2001-07-10 12:31:43 |
| Message-ID: | Pine.LNX.4.33.0107101424400.5824-400000@sensenet.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-jdbc pgsql-patches |
> > I have some issues with this patch.
> >
> > 1) Please don't require the driver to perform yet another round trip to
> > the server to get the database encoding. You changed the following code
> > which accessed the server once at connection creation:
> [snip]
> > 2) I don't like having test specific code in Encoding.java, specifically
> > the dummy encoding 'X-UNIT-TESTS'.
Ok, now I've made the changes, and added a comment about why the code for
(1) should stay optimized. :)
/Anders
_____________________________________________________________________
A n d e r s B e n g t s s o n ndrsbngtssn(at)yahoo(dot)se
Stockholm, Sweden
| Attachment | Content-Type | Size |
|---|---|---|
| EncodingTest.java | text/plain | 1.2 KB |
| Encoding.java | text/plain | 4.0 KB |
| encoding.patch | text/plain | 13.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2001-07-10 14:57:54 | Re: DatabaseMetaData.getCatalogs() |
| Previous Message | Anders Bengtsson | 2001-07-10 10:35:26 | Re: [PATCH] Cleanup of JDBC character encoding |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jason Tishler | 2001-07-10 13:51:22 | Re: Python (PyGreSQL) make install patch |
| Previous Message | Anders Bengtsson | 2001-07-10 10:35:26 | Re: [PATCH] Cleanup of JDBC character encoding |