From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Anders Bengtsson <ndrsbngtssn(at)yahoo(dot)se> |
Cc: | Barry Lind <barry(at)xythos(dot)com>, pgsql-jdbc(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: Re: [PATCHES] Re: [PATCH] Cleanup of JDBC character encoding |
Date: | 2001-07-12 20:34:59 |
Message-ID: | 200107122034.f6CKYxB29367@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-jdbc pgsql-patches |
Your patch has been added to the PostgreSQL unapplied patches list at:
http://candle.pha.pa.us/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
>
> > > I have some issues with this patch.
> > >
> > > 1) Please don't require the driver to perform yet another round trip to
> > > the server to get the database encoding. You changed the following code
> > > which accessed the server once at connection creation:
> > [snip]
> > > 2) I don't like having test specific code in Encoding.java, specifically
> > > the dummy encoding 'X-UNIT-TESTS'.
>
> Ok, now I've made the changes, and added a comment about why the code for
> (1) should stay optimized. :)
>
> /Anders
> _____________________________________________________________________
> A n d e r s B e n g t s s o n ndrsbngtssn(at)yahoo(dot)se
> Stockholm, Sweden
Content-Description:
[ Attachment, skipping... ]
Content-Description:
[ Attachment, skipping... ]
Content-Description:
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Barry Lind | 2001-07-12 21:16:41 | Patch for handling long null terminated strings in JDBC driver |
Previous Message | Bruce Momjian | 2001-07-12 20:12:44 | Re: [PATCHES] Re: [PATCH] Cleanup of JDBC character encoding |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2001-07-12 20:35:51 | Re: patch for spelling mistake |
Previous Message | Bruce Momjian | 2001-07-12 20:12:44 | Re: [PATCHES] Re: [PATCH] Cleanup of JDBC character encoding |