| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Subject: | Re: Warnings triggered by recent includefile cleanups |
| Date: | 2000-07-19 16:28:51 |
| Message-ID: | Pine.LNX.4.21.0007190132550.1545-100000@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane writes:
> @@ -55,6 +55,13 @@
> #include "postgres.h"
> #ifdef HAVE_LIMITS_H
> #include <limits.h>
> +#ifndef MAXINT
> +#define MAXINT INT_MAX
> +#endif
> +#else
> +#ifdef HAVE_VALUES_H
> +#include <values.h>
> +#endif
> #endif
> #include "fmgr.h"
> #include "utils/builtins.h"
>
> was dead code when it was installed. The CVS log says
> values.h patch from Alex Howansky
He claimed that the compilation failed for him in the files
src/backend/optimizer/path/costsize.c
src/backend/utils/adt/date.c
src/backend/utils/adt/float.c
because MAXINT was undefined (although neither date.c nor float.c used
MAXINT at all in 6.5).
This problem is gone and one should use INT_MAX anyway.
--
Peter Eisentraut Sernanders väg 10:115
peter_e(at)gmx(dot)net 75262 Uppsala
http://yi.org/peter-e/ Sweden
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2000-07-19 16:52:38 | Re: btree split logic is fragile in the presence of large index items |
| Previous Message | Peter Eisentraut | 2000-07-19 16:27:33 | Re: btree split logic is fragile in the presence of large index items |