Re: freefuncs.c is never called from anywhere!?

From: Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: freefuncs.c is never called from anywhere!?
Date: 2000-06-09 17:19:15
Message-ID: Pine.LNX.3.96.1000609190835.7056C-100000@ara.zf.jcu.cz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Fri, 9 Jun 2000, Tom Lane wrote:

> > Any status on this?
>
> Nothing done about it yet.
>
> IIRC, some people were concerned about the fact that freeObject()
> couldn't possibly cope with circular structures, multiply-linked
> subexpressions, etc. I don't think that's a problem for my intended
> use in the relcache --- the only structures I'll be freeing are ones
> previously read in by the node-reading functions, and those aren't
> going to have any surprises like that.

IMHO use separate memory context will better and more fast way than
freeObject(). I use this method in my suggested query cache and in the
SPI (in SPI_freeplan()) and it is very good (without potential leaks).

All in backend/nodes are (IMHO) very dificult keep up and recursion is
and not gratis feature too. (Homework: write PG in Fortran :-)

Karel

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2000-06-09 17:29:26 Re: Fix for RENAME
Previous Message Bruce Momjian 2000-06-09 17:10:46 Re: freefuncs.c is never called from anywhere!?]