| From: | Karel Zak - Zakkr <zakkr(at)zf(dot)jcu(dot)cz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp>, pgsql-hackers <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: [HACKERS] Cache query (PREPARE/EXECUTE) |
| Date: | 2000-02-23 17:11:22 |
| Message-ID: | Pine.LNX.3.96.1000223180302.15013F-100000@ara.zf.jcu.cz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 23 Feb 2000, Tom Lane wrote:
> "Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp> writes:
> > I think so. The problem is that Node struct couldn't be freed safely
> > due to the lack of reference count in its definition. As far as I see
> > plans could be destroyed only when the memory context in which
> > they are placed are destroyed.
>
> This is overly conservative. It should be safe to destroy a plan tree
> via freeObject() if it was created via copyObject() --- and that is
> certainly how the plan would get into a permanent memory context.
Yes, SPI and my PREPARE use copyObject() for saving to TopMemoryContext.
Well, I believe you Tom that freeObject() is correct and I start
implement PlanCacheMemoryContext's routines for PREPARE (and
SPI's saveplan ?).
Karel Z.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hiroshi Inoue | 2000-02-23 17:34:04 | RE: [HACKERS] Cache query (PREPARE/EXECUTE) |
| Previous Message | Bruce Momjian | 2000-02-23 17:08:14 | Re: [HACKERS] Beta for 4:30AST ... ? |