| From: | Jeremy Drake <pgsql(at)jdrake(dot)com> |
|---|---|
| To: | Gregory Stark <stark(at)enterprisedb(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Neil Conway <neilc(at)samurai(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, David Fetter <david(at)fetter(dot)org>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>, Mark Dilger <pgsql(at)markdilger(dot)com> |
| Subject: | Re: patch adding new regexp functions |
| Date: | 2007-03-22 05:17:03 |
| Message-ID: | Pine.BSO.4.64.0703212215250.19070@resin.csoft.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
On Wed, 21 Mar 2007, Gregory Stark wrote:
> The only thing I would say is that this should maybe be a TextGetDatum() just
> for code hygiene. It should be exactly equivalent though:
I could not find such a thing using ctags, nor TextPGetDatum(). I looked
at PG_RETURN_TEXT_P and it just uses PG_RETURN_POINTER, which in turn uses
PointerGetDatum. If there is such a thing, it is well camoflaged...
--
If you think the problem is bad now, just wait until we've solved it.
-- Arthur Kasspe
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeremy Drake | 2007-03-22 05:21:28 | Re: patch adding new regexp functions |
| Previous Message | Tom Lane | 2007-03-22 05:15:39 | Re: Proposal: Adding JIS X 0213 support |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeremy Drake | 2007-03-22 05:21:28 | Re: patch adding new regexp functions |
| Previous Message | Tom Lane | 2007-03-22 04:42:23 | Re: patch adding new regexp functions |