Re: recent --with-libxml support

From: Jeremy Drake <pgsql(at)jdrake(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: recent --with-libxml support
Date: 2006-12-24 06:19:02
Message-ID: Pine.BSO.4.64.0612232213430.8221@resin.csoft.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, 23 Dec 2006, Tom Lane wrote:

> Ah-hah, I've sussed it. sqlchar_to_unicode() calls the
> mb2wchar_with_len converters, which are defined to return a *null
> terminated* pg_wchar string. So even if you only ask for the conversion
> of a single character, you need a 2-pg_wchar array to hold the result,
> and that wasn't being allocated. So the code was clobbering a word of
> stack space that evidently is critical on some machines and not others.
>
> Fix committed, please see if it works for you now.

The buildfarm run seems to be green now. I am compiling a sandbox to test
it manually now, but I'm pretty sure that fixed it. Yep, the make check
works there too...

--
As long as war is regarded as wicked, it will always have its
fascination. When it is looked upon as vulgar, it will cease to be
popular.
-- Oscar Wilde

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikolay Samokhvalov 2006-12-24 08:58:52 How to gain R/W access to developers wiki?
Previous Message tomas 2006-12-24 05:21:03 Re: quick review