Re: AW: [HACKERS] freefuncs.c is never called from anywhere!?

From: The Hermit Hacker <scrappy(at)hub(dot)org>
To: Zeugswetter Andreas SB <ZeugswetterA(at)wien(dot)spardat(dot)at>
Cc: "'pgsql-hackers(at)postgreSQL(dot)org'" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: AW: [HACKERS] freefuncs.c is never called from anywhere!?
Date: 2000-02-02 13:11:02
Message-ID: Pine.BSF.4.21.0002020910320.411-100000@thelab.hub.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 2 Feb 2000, Zeugswetter Andreas SB wrote:

>
> > > (In the same spirit it would also be nice to tag NOT_USED
> > sections with a
> > > version number, so it could be yanked two or three releases past.)
> >
> > Why not just yank it period? 'cvs diff' will show what was
> > yanked, and
> > the log message could say just 'yanked NOT_USED code from
> > source tree'...
>
> Once GetAttributeBy[Num|Name] was yanked, because it was not referenced
> inside the code. It is heavily used in extensions though.
>
> For me it was relatively easy to find the problem, because it was ifdef'd
> NOT_USED.
> I am not sure if I had found it that easily, if the "old" code would have
> only been in cvs.

Maybe date/release stamp a NOT_USED and if after X releases, yank it as
not being relevant ... at least in cases like this ...

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff MacDonald <jeff@pgsql.com> 2000-02-02 14:02:15 WinNT compiling: ongoing
Previous Message Peter Eisentraut 2000-02-02 11:37:48 Re: [HACKERS] RE: cvs-commit-digest V1 #856