Re: PGAdmin 3 Patch // Memory Leaks Fixed // Ignore

> > I'm really confused as to why it's not showing any
> > tables/views ... the function is below.
>
> It's because I had System Objects turned off, and as your definition of
> a system object is relowner > 1, it ignored all my objects which are
> owned by user postgres, id = 1!!!
>
> What you need to do is discount tables and views if they are in the
> pg_catalog, pg_temp_* or pg_toast namespaces, and columns is attnum < 1.

Dave,

Okay, that change is made. Now I do a join with pg_namespace.oid =
pg_class.relnamespace and it looks like it's working. And for columns, I
changed attnum >= 0 to attnum > 0 and it works as indicated. It will be
functional in the next patch.

> > As for the SQL tab,
> > it's one way (for now ... which reminds me, do we have a
> > "deconstruct sql" function lying around?)
>
> Umm, no. The closest we have is in the query tool in pgAdmin II and it's
> big, complex and occasionally falls over. Perhaps we can steal some of
> the PostgreSQL parser code for pgAdmin III? I know nothing about how
> that works though.

Yeah, that might be possible, but it will take some work. I did some cursory
investigation, and a lot of function names and defines in pgsql conflict
with the MS and wxWindows libraries. For right now I'm just building a small
regex doodad to split everything up. It's working pretty well. Unfortunately
the regex library that comes with WX is POSIX instead of PCRE. Oh well, I
know both syntaxes, I'm just much more familiar with PCRE.

For now I will make the SQL box read-only. I know there are other solutions,
but are too costly to implement right now.

> Anyway, now it does some things here, it looks excellent - Nice work!!

Thanks. The next patch will add tons of functionality. At this point it can
create 85% of the queries you'd ever build.

> > I'm using this program called TortoiseCVS. I can't get WinCVS
> > to work to save my life.
>
> Funny that, I could never get TortoiseCVS to work!

Okay, I added certain files to .cvsignore ... hopefully the patches work
better now.

-Keith