Minor bug and suggested fix - 1.2 and 1.3.5

From: "Mark A(dot) Taff" <mark(at)libertycreek(dot)net>
To: "pgadmin-hackers" <pgadmin-hackers(at)postgresql(dot)org>
Subject: Minor bug and suggested fix - 1.2 and 1.3.5
Date: 2002-02-14 15:48:28
Message-ID: LOBBLBDHPFLLCMMKPMFKEECFDDAA.mark@libertycreek.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

All,
I’ve found a minor bug in 1.2 and 1.3.5. When an uncorrected
error occurs and LogError is called after StartMsg has been called, EndMsg
is not always called, and so the cursor does not always return to a normal
cursor. Rather than trying to check and correct for this throughout the
code, I’ve just done it once in the LogError sub. I’ve pasted patched code
based on 1.3.5 for your consideration below.

Regards,

Mark Taff

*** Begin patch for pgAdmin2.basMisc.LogError v1.3.5 ***

Public Sub LogError(lError As Long, szError As String, szRoutine As String)
'No logging here, if anythings going wrong then we want the real error

frmMain.svr.LogEvent "Error in " & szRoutine & ": " & lError & " - " &
szError, etErrors
MsgBox "An error has occured in " & szRoutine & ":" & vbCrLf & vbCrLf &
"Number: " & lError & vbCrLf & "Description: " & szError, vbExclamation,
App.Title & " Error"

'If we get here, EndMsg may not fire, so give the user a normal cursor...
Screen.MousePointer = vbDefault

End Sub

*** End patch ***

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2002-02-14 16:05:09 Re: Minor bug and suggested fix - 1.2 and 1.3.5
Previous Message sreedhar 2002-02-13 11:23:33 [ADMIN] Problem while connecting pgAdmin II v1.2