Re: [RRR] Tests citext casts

From: "David E(dot) Wheeler" <david(at)kineticode(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Kenneth Marshall <ktm(at)rice(dot)edu>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [RRR] Tests citext casts
Date: 2008-11-07 20:26:56
Message-ID: FBF95408-254D-4C05-987D-DE6610035904@kineticode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-rrreviewers

On Nov 7, 2008, at 12:12 PM, Tom Lane wrote:

> ... and you have very limited visibility into what went wrong, if
> anything goes wrong. That's not real attractive for the buildfarm
> environment. I like being able to see the actual query output.

It depends on how you write it - you can add a lot of descriptive
information about what's being tested in each assertion. To me, the
results are the most important, and I can look in the test file for
the troubling code.

Anyway, we all like what we're used to, I guess.

Best,

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-11-07 20:27:36 Re: gram.y=>preproc.y II
Previous Message Zdenek Kotala 2008-11-07 20:24:20 Re: [WIP] In-place upgrade

Browse pgsql-rrreviewers by date

  From Date Subject
Next Message Alex Hunsaker 2008-11-07 20:45:39 pre-MED done, ready for new patch
Previous Message Tom Lane 2008-11-07 20:12:52 Re: [RRR] Tests citext casts