Re: Solve a problem of LC_TIME of windows.

From: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
To: "Magnus Hagander" <magnus(at)hagander(dot)net>, "ITAGAKI Takahiro" <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: "Hiroshi Inoue" <inoue(at)tpf(dot)co(dot)jp>, "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Solve a problem of LC_TIME of windows.
Date: 2009-01-09 15:57:08
Message-ID: F278A87FA2394C61A7C0FB1917D599DC@HIRO57887DE653
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Hi.

Thanks all.!!!!

I tried CVS-HEAD now.

================================================
HIROSHI=# select to_char(now(),'TMDay');
to_char
----------
Saturday
(1 行)

HIROSHI=# set LC_MESSAGES=Ja;
SET
HIROSHI=# select to_char(now(),'TMDay');
to_char
----------
Saturday
(1 行)
================================================

Umm, It does not look at a comfortable result.:-(
I will check it on tomorrow night. sorry busy now..

Regards,
Hiroshi Saito

----- Original Message -----
From: "Magnus Hagander" <magnus(at)hagander(dot)net>

> ITAGAKI Takahiro wrote:
>> Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp> wrote:
>>
>>> Seems LC_CTYPE and LC_TIME should be convertible even though we use
>>> wcsftime (which internally calls strftime?).
>>
>> Ok, wcsftime() requries both LC_TIME and LC_CTYPE are the same setting
>> (at least encoding) on Windows.
>>
>> The attached patch is an updated version to fix cache_locale_time().
>> Now it sets LC_TIME and LC_CTYPE to the specified locale and restore
>> them at end of the function. I tested the patch on Windows XP Japanese
>> Edition (SJIS) with UTF-8 and EUCJP databases, and worked expectedly.
>>
>> "#ifdef WIN32" codes seems to be ugly in the patch,
>> but I have no other idea...
>
> I have applied this version of the patch (with only a minor further
> addition to the comment).
>
> Thank you all for your work and patience in getting this fixed! Let's
> hope it stays fixed :-)
>
> //Magnus
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2009-01-09 15:58:21 Re: Improving compressibility of WAL files
Previous Message Andrew Dunstan 2009-01-09 15:21:46 Re: foreign_data test fails with non-C locale

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2009-01-09 16:12:05 Re: Solve a problem of LC_TIME of windows.
Previous Message Magnus Hagander 2009-01-09 13:05:03 Re: Solve a problem of LC_TIME of windows.