Re: Possible bug in vacuum redo

From: "Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Vadim Mikheev" <vmikheev(at)sectorbase(dot)com>
Cc: <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Possible bug in vacuum redo
Date: 2001-12-22 15:52:37
Message-ID: EKEJJICOHDIEMGPNIFIJEEIKGEAA.Inoue@tpf.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> -----Original Message-----
> From: Tom Lane
>
> In the vacuum tuple-chain moving logic, shouldn't the lines that update
> the new tuple's t_ctid (vacuum.c lines 1882-1891 in current sources)
> be moved up to before the log_heap_move call at line 1866?
>
> It appears to me that as the code stands, log_heap_move will log the new
> tuple containing the wrong t_ctid; therefore, if we crash and have to
> redo the transaction from WAL, the wrong t_ctid will be restored. No?

AFAIR t_ctid isn't logged in WAL.

regards,
Hiroshi Inoue

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2001-12-22 16:13:34 Re: Possible bug in vacuum redo
Previous Message Peter Eisentraut 2001-12-22 08:30:47 Re: contrib idea