Re: [PATCH] Improve Cmd-Q / Exit-Menu-Item on OSX

Thanks Florian, patch applied.

Regards, Dave

> -----Original Message-----
> From: pgadmin-hackers-owner(at)postgresql(dot)org
> [mailto:pgadmin-hackers-owner(at)postgresql(dot)org] On Behalf Of
> Florian G. Pflug
> Sent: 24 April 2005 20:55
> To: pgadmin-hackers
> Subject: [pgadmin-hackers] [PATCH] Improve Cmd-Q /
> Exit-Menu-Item on OSX
>
> Hi
>
> Turns out that wxMac actually supports a macish behaviour of
> the "Quit" MenuItem. It works similar to the About and Help menu
> handling - you just set s_macEditMenuItemId to the id of
> the Exit-Menuitem, and wx takes care of the rest.
>
> Here is is patch (3-liner, including the compiler conditionals)
> for this.
>
> ---------------- cut here ------------------------------------
> Index: src/ui/frmMain.cpp
> ===================================================================
> RCS file: /projects/pgadmin3/src/ui/frmMain.cpp,v
> retrieving revision 1.128
> diff -a -u -r1.128 frmMain.cpp
> --- src/ui/frmMain.cpp 24 Apr 2005 12:19:50 -0000 1.128
> +++ src/ui/frmMain.cpp 24 Apr 2005 19:38:02 -0000
> @@ -178,6 +178,9 @@
> fileMenu->Append(MNU_HBAFILECONFIG, _("Open
> pg_hba.conf"), _("Open configuration editor
> with pg_hba.conf."));
> fileMenu->AppendSeparator();
> fileMenu->Append(MNU_EXIT, _("E&xit\tAlt-F4"),
> _("Quit this program."));
> +#ifdef __WXMAC__
> + wxApp::s_macExitMenuItemId = MNU_EXIT ;
> +#endif
> menuBar->Append(fileMenu, _("&File"));
>
> // Edit Menu
> ------------------------ cut here -----------------------------
>
> Please apply. (This is not sent as an attachment, because
> I had trouble getting attachments through to the list...)
>
> Greetings, Florian Pflug
>