Re: Disallow premature is broken

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "Ludek Finstrle" <luf(at)pzkagis(dot)cz>, <pgsql-odbc(at)postgresql(dot)org>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Disallow premature is broken
Date: 2006-01-27 09:39:05
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E40103DB91@ratbert.vale-housing.co.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-odbc

> -----Original Message-----
> From: pgsql-odbc-owner(at)postgresql(dot)org
> [mailto:pgsql-odbc-owner(at)postgresql(dot)org] On Behalf Of Ludek Finstrle
> Sent: 25 January 2006 22:50
> To: pgsql-odbc(at)postgresql(dot)org
> Subject: [ODBC] Disallow premature is broken
>
> Hello,
>
> Dmitry pointed me that Disallow premature is next broken feature.
> I found next difference between old driver and new one.
>
> When there are more statements in one (using semicolon ';') that
> 07.03 driver returns more results QResultClass. The 08.01 one
> returns only one QResultClass. The example of such mutlistatement is:
> "BEGIN; SELECT * FROM table; COMMIT". The old driver returns 3
> QResultClass but 08.01 driver returns only last result (from COMMIT)
> QResultClass.
> This behaviour breaks Disallow premature so it fails with access
> violation. I can fix it becouse now we are using PQgetResult. But I'm
> not sure if it doesn't break something another.
>
> I could fix a little the Disallow premature so it doesn't fail
> with access violation but it doesn't work at all.
>
> What do you think? How do we want change the behaviout before
> releasing new stable release? I'm not sure. There is no much time
> for testing new behaviour. The multistatements hasn't been reported
> yet by users. It seems this feature isn't widely used.

Yuck. My first thought is that we need to try to parse the query string
and extract the last result returning query, but perhaps we would be
better to look at returning multiple results again.

In the short term though, I say just stop it crashing and let's get a
release out seeing as Tom is getting antsy about FC5 :-)

Can you produce a final 08.01.0108 dev build, and I'll look to build
08.01.0200 on say Tuesday/Wednesday? Does that work for you Tom?

Regards, Dave

Responses

Browse pgsql-odbc by date

  From Date Subject
Next Message Dave Page 2006-01-27 09:40:01 Re: Odbcapi30.c - 64 bit compiler warning cleanup
Previous Message Ludek Finstrle 2006-01-27 09:31:00 Re: Odbcapi30.c - 64 bit compiler warning cleanup