pgsql: Fix RelationIdGetRelation calls that weren't bothering with erro

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix RelationIdGetRelation calls that weren't bothering with erro
Date: 2019-09-08 21:01:20
Message-ID: E1i74JE-00024V-9J@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-committers pgsql-hackers

Fix RelationIdGetRelation calls that weren't bothering with error checks.

Some of these are quite old, but that doesn't make them not bugs.
We'd rather report a failure via elog than SIGSEGV.

While at it, uniformly spell the error check as !RelationIsValid(rel)
rather than a bare rel == NULL test. The machine code is the same
but it seems better to be consistent.

Coverity complained about this today, not sure why, because the
mistake is in fact old.

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/69f883fef14a3fc5849126799278abcc43f40f56

Modified Files
--------------
src/backend/access/heap/heapam.c | 3 +++
src/backend/replication/logical/reorderbuffer.c | 8 ++++++--
2 files changed, 9 insertions(+), 2 deletions(-)

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2019-09-09 02:12:22 BUG #15995: VACUUM not working after setting/unsetting of archive_mode = on, wal_level = replica
Previous Message Peter Eisentraut 2019-09-08 20:27:49 Re: BUG #15977: Inconsistent behavior in chained transactions

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2019-09-08 21:54:12 Re: pgsql: Use data directory inode number, not port, to select SysV resour
Previous Message Alexander Korotkov 2019-09-08 19:31:12 pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2019-09-08 21:46:35 Re: MSVC buildfarm critters are not running modules' TAP tests
Previous Message Alexander Korotkov 2019-09-08 20:35:47 Re: [PATCH] kNN for btree