| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Fix CRC check handling in get_controlfile |
| Date: | 2016-09-28 16:37:59 |
| Message-ID: | E1bpHrr-00013s-Us@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix CRC check handling in get_controlfile
The previous patch broke this by returning NULL for a failed CRC check,
which pg_controldata would then try to read. Fix by returning the
result of the CRC check in a separate argument.
Michael Paquier and myself
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/e79e6c4da152154544913b38354b98d07b65e411
Modified Files
--------------
src/backend/utils/misc/pg_controldata.c | 20 ++++++++++++--------
src/bin/pg_controldata/pg_controldata.c | 5 +++--
src/bin/pg_ctl/pg_ctl.c | 24 +++++++-----------------
src/common/controldata_utils.c | 19 +++++++++----------
src/include/common/controldata_utils.h | 2 +-
5 files changed, 32 insertions(+), 38 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2016-09-28 16:38:28 | Re: [COMMITTERS] pgsql: pg_ctl: Detect current standby state from pg_control |
| Previous Message | Robert Haas | 2016-09-28 15:27:34 | pgsql: Fix dangling pointer problem in ReorderBufferSerializeChange. |