pgsql: Fix instability in parallel regression tests.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix instability in parallel regression tests.
Date: 2016-08-25 13:58:28
Message-ID: E1bcvAq-0004pv-Iq@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix instability in parallel regression tests.

Commit f0c7b789a added a test case in case.sql that creates and then drops
both an '=' operator and the type it's for. Given the right timing, that
can cause a "cache lookup failed for type" failure in concurrent sessions,
which see the '=' operator as a potential match for '=' in a query, but
then the type is gone by the time they inquire into its properties.
It might be nice to make that behavior more robust someday, but as a
back-patchable solution, adjust the new test case so that the operator
is never visible to other sessions. Like the previous commit, back-patch
to all supported branches.

Discussion: <5983(dot)1471371667(at)sss(dot)pgh(dot)pa(dot)us>

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/5b79dd6eddeecc656ecf5fd85a61a2a3fa170efa

Modified Files
--------------
src/test/regress/expected/case.out | 9 ++++-----
src/test/regress/sql/case.sql | 11 ++++++-----
2 files changed, 10 insertions(+), 10 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2016-08-25 19:56:09 Re: [COMMITTERS] pgsql: Add the "snapshot too old" feature
Previous Message Tom Lane 2016-08-25 02:20:42 pgsql: Fix small query-lifespan memory leak in bulk updates.