From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Avoid possible crash in contrib/bloom's blendscan(). |
Date: | 2016-05-17 21:01:24 |
Message-ID: | E1b2m7I-0007sk-BP@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Avoid possible crash in contrib/bloom's blendscan().
It's possible to begin and end an indexscan without ever calling
amrescan. contrib/bloom, unlike every other index AM, allocated
its "scan->opaque" storage at amrescan time, and thus would crash
in amendscan if amrescan hadn't been called. We could fix this
by putting in a null-pointer check in blendscan, but I see no very
good reason why contrib/bloom should march to its own drummer in
this respect. Let's move that initialization to blbeginscan
instead. Per report from Jeff Janes.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/e13ac5586c49c77f301329b79bd7e8f489d0e66f
Modified Files
--------------
contrib/bloom/blscan.c | 26 ++++++++++----------------
1 file changed, 10 insertions(+), 16 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-05-17 21:48:57 | Re: Re: [COMMITTERS] pgsql: Allocate all page images at once in generic wal interface |
Previous Message | Teodor Sigaev | 2016-05-17 19:50:35 | Re: [COMMITTERS] pgsql: Allocate all page images at once in generic wal interface |