pgsql: postgres_fdw: Fix the fix for crash when pushing down multiple j

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: postgres_fdw: Fix the fix for crash when pushing down multiple j
Date: 2016-05-16 16:07:59
Message-ID: E1b2L3n-0005pQ-LM@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

postgres_fdw: Fix the fix for crash when pushing down multiple joins.

Commit 3151f16e1874db82ed85a005dac15368903ca9fb was intended to be
a commit of a patch from Ashutosh Bapat, but instead I mistakenly
committed an earlier version from Michael Paquier (because both
patches were submitted with the same filename, and I confused them).
Michael's patch fixes the crash but doesn't actually implement the
correct test.

Repair the incorrect logic, and also expand the comments considerably
so that this is all more clear.

Ashutosh Bapat and Robert Haas

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/02a568a02769ca626591039f460109369bf05dc2

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 68 ++++++++++++++++++++++++++
contrib/postgres_fdw/postgres_fdw.c | 36 ++++++++++++--
contrib/postgres_fdw/sql/postgres_fdw.sql | 10 ++++
3 files changed, 110 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Teodor Sigaev 2016-05-16 21:01:53 pgsql: Correctly align page's images in generic wal API
Previous Message Robert Haas 2016-05-16 15:24:51 pgsql: Fix multiple problems in postgres_fdw query cancellation logic.