pgsql: Make WAL-related utilities handle .partial WAL files properly.

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Make WAL-related utilities handle .partial WAL files properly.
Date: 2015-07-03 02:55:08
Message-ID: E1ZAr88-0008Jy-Om@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make WAL-related utilities handle .partial WAL files properly.

Commit de76884 changed an archive recovery so that the last WAL
segment with old timeline was renamed with suffix .partial. It should
have updated WAL-related utilities so that they can handle such
.paritial WAL files, but we forgot that.

This patch changes pg_archivecleanup so that it can clean up even
archived WAL files with .partial suffix. Also it allows us to specify
.partial WAL file name as the command-line argument "oldestkeptwalfile".

This patch also changes pg_resetxlog so that it can remove .partial
WAL files in pg_xlog directory.

pg_xlogdump cannot handle .partial WAL files. Per discussion,
we decided only to document that limitation instead of adding the fix.
Because a user can easily work around the limitation (i.e., just remove
.partial suffix from the file name) and the fix seems complicated for
very narrow use case.

Back-patch to 9.5 where the problem existed.

Review by Michael Paquier.
Discussion: http://www.postgresql.org/message-id/CAHGQGwGxMKnVHGgTfiig2Bt_2djec0in3-DLJmtg7+nEiidFdQ@mail.gmail.com

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/eeaf1b6afacba0fc0a0e1878c2ed23f4fceef039

Modified Files
--------------
doc/src/sgml/ref/pg_xlogdump.sgml | 6 +++++
doc/src/sgml/ref/pgarchivecleanup.sgml | 6 +++--
src/bin/pg_archivecleanup/pg_archivecleanup.c | 31 +++++++++++++++++++++----
src/bin/pg_resetxlog/pg_resetxlog.c | 10 +++++---
4 files changed, 43 insertions(+), 10 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2015-07-03 03:15:28 Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file
Previous Message Tom Lane 2015-07-02 22:13:42 pgsql: Improve pg_restore's -t switch to match all types of relations.