pgsql: Process withCheckOption exprs in setrefs.c

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Process withCheckOption exprs in setrefs.c
Date: 2014-09-23 00:22:51
Message-ID: E1XWDsZ-00054p-Na@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Process withCheckOption exprs in setrefs.c

While withCheckOption exprs had been handled in many cases by
happenstance, they need to be handled during set_plan_references and
more specifically down in set_plan_refs for ModifyTable plan nodes.
This is to ensure that the opfuncid's are set for operators referenced
in the withCheckOption exprs.

Identified as an issue by Thom Brown

Patch by Dean Rasheed

Back-patch to 9.4, where withCheckOption was introduced.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/6ef8c658af2127f4e62cb24feade8b465c9e2fea

Modified Files
--------------
src/backend/optimizer/plan/setrefs.c | 3 +++
src/test/regress/expected/updatable_views.out | 20 ++++++++++++++++++++
src/test/regress/sql/updatable_views.sql | 19 +++++++++++++++++++
3 files changed, 42 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2014-09-23 00:53:57 pgsql: Log ALTER SYSTEM statements as DDL
Previous Message Andres Freund 2014-09-22 21:48:21 pgsql: Remove most volatile qualifiers from xlog.c