pgsql: Fix portability issue in ordered-set patch.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix portability issue in ordered-set patch.
Date: 2013-12-24 01:24:13
Message-ID: E1VvGjF-0004k1-4f@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix portability issue in ordered-set patch.

Overly compact coding in makeOrderedSetArgs() led to a platform dependency:
if the compiler chose to execute the subexpressions in the wrong order,
list_length() might get applied to an already-modified List, giving a
value we didn't want. Per buildfarm.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/cf63c641cae2063a0442d73d49af295301cec61b

Modified Files
--------------
src/backend/parser/gram.y | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2013-12-24 01:52:46 pgsql: Revise documentation for new freezing method.
Previous Message Tom Lane 2013-12-23 21:11:52 pgsql: Support ordered-set (WITHIN GROUP) aggregates.