pgsql: pg_upgrade: Report full disk better

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: pg_upgrade: Report full disk better
Date: 2013-11-19 03:07:41
Message-ID: E1VibfB-0000vs-A4@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_upgrade: Report full disk better

Previously, pg_upgrade would abort copy_file() on a short write without
setting errno, which the caller would report as an error with the
message "Success". We assume ENOSPC in that case, as we do elsewhere in
the code. Also set errno in some other error cases in copy_file() to
avoid bogus "Success" error messages.

This was broken in 6b711cf37c228749b6a8cef50e16e3c587d18dd4, so 9.2 and
before are OK.

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/8ca75671bd583f2e814c865941da464d2419312c

Modified Files
--------------
contrib/pg_upgrade/file.c | 9 +++++++++
1 file changed, 9 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2013-11-19 13:11:30 Re: SSL renegotiation
Previous Message Andres Freund 2013-11-18 21:40:54 Re: pgsql: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized pag