From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Improve EXPLAIN's ability to cope with LATERAL references in pla |
Date: | 2012-08-30 16:57:06 |
Message-ID: | E1T783G-00058H-D7@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Improve EXPLAIN's ability to cope with LATERAL references in plans.
push_child_plan/pop_child_plan didn't bother to adjust the "ancestors"
list of parent plan nodes when descending to a child plan node. I think
this was okay when it was written, but it's not okay in the presence of
LATERAL references, since a subplan node could easily be returning a
LATERAL value back up to the same nestloop node that provides the value.
Per changed regression test results, the omission led to failure to
interpret Param nodes that have perfectly good interpretations.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/d1a4db8d25ec53fd17e99168bc5efa0b16ef6fed
Modified Files
--------------
src/backend/utils/adt/ruleutils.c | 18 ++++++++++--------
src/test/regress/expected/join.out | 2 +-
2 files changed, 11 insertions(+), 9 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2012-08-30 17:10:02 | pgsql: Fix logic bug in gistchoose and gistRelocateBuildBuffersOnSplit. |
Previous Message | Robert Haas | 2012-08-30 14:42:50 | pgsql: Comment fixes. |