pgsql: Remove debug logging for pgstat wait timeout.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove debug logging for pgstat wait timeout.
Date: 2011-09-16 22:25:41
Message-ID: E1R4gqr-0007Dh-IX@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove debug logging for pgstat wait timeout.

This reverts commit 79b2ee20c8a041a85dd230c4e787bef22edae57b, which proved
to not be very informative; it looks like the "pgstat wait timeout"
warnings in the buildfarm are just a symptom of running on heavily loaded
machines, and there isn't any weird mechanism causing them to appear.

To try to reduce the frequency of buildfarm failures from this effect,
increase PGSTAT_MAX_WAIT_TIME from 5 seconds to 10.

Also, arrange to not send a fresh inquiry message every single time through
the loop, as that seems more likely to cause problems (by swamping the
collector) than fix them. We'll now send an inquiry the first time through
the delay loop, and every 640 msec thereafter.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/99b5454167aab89b94f171e4318ef12443c6cfc4

Modified Files
--------------
src/backend/postmaster/pgstat.c | 37 +++++++++++--------------------------
1 files changed, 11 insertions(+), 26 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-09-17 05:48:37 pgsql: Fix Assert failure in new plancache code.
Previous Message Tom Lane 2011-09-16 20:36:10 pgsql: Add FORCE_NOT_NULL support to the file_fdw foreign data wrapper.