pgsql: In the final emptying phase of the new GiST buffering build, set

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: In the final emptying phase of the new GiST buffering build, set
Date: 2011-09-12 12:11:47
Message-ID: E1R35MZ-0006aH-Kr@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

In the final emptying phase of the new GiST buffering build, set the
queuedForEmptying flag correctly on buffer when adding it to the queue.
Also, don't add buffer to the queue if it's there already. These were
harmless oversights; failing to set the flag just means that a buffer might
get added to the queue twice if more tuples are added to it (although that
can't actually happen at this point because all the upper buffers have
already been emptied), and having the same buffer twice in the emptying
queue is harmless. But better be tidy.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/8caf6132c7498b2b9400a5496a29e48c1c0aa516

Modified Files
--------------
src/backend/access/gist/gistbuild.c | 12 ++++++++----
1 files changed, 8 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2011-09-12 19:11:21 Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge
Previous Message Tom Lane 2011-09-11 20:29:53 pgsql: Invent a new memory context primitive, MemoryContextSetParent.